[pull] main from bazel-contrib:main#425
Merged
Merged
Conversation
It seems `$ORIGIN` resolves prior to symlink resolution. This makes it resolve differently depending on if the directory or file itself is symlinked. To fix, special case shared libraries and have them symlinked directly. Since an explicit file is the target, `VenvSymlinkEntry.link_to_file` is added to hold the File object that will be linked to. An unfortunate side-effect of this logic is any package with `lib*.so` files will be more expensive to build (depset flattened at analysis time, more files symlinked), but it beats not working at all. Optimizing that can be done in another change. Tests added to generate libraries that look like what something from PyPI does. Manually verified a case using jax and jax plugins. Fixes #3228
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )