Skip to content

[pull] main from bazel-contrib:main#425

Merged
pull[bot] merged 1 commit into
garymm:mainfrom
bazel-contrib:main
Oct 11, 2025
Merged

[pull] main from bazel-contrib:main#425
pull[bot] merged 1 commit into
garymm:mainfrom
bazel-contrib:main

Conversation

@pull

@pull pull Bot commented Oct 11, 2025

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

It seems `$ORIGIN` resolves prior to symlink resolution. This makes it
resolve
differently depending on if the directory or file itself is symlinked.

To fix, special case shared libraries and have them symlinked directly.
Since an
explicit file is the target, `VenvSymlinkEntry.link_to_file` is added to
hold the
File object that will be linked to.

An unfortunate side-effect of this logic is any package with `lib*.so`
files
will be more expensive to build (depset flattened at analysis time, more
files
symlinked), but it beats not working at all. Optimizing that can be done
in
another change.

Tests added to generate libraries that look like what something from
PyPI
does. Manually verified a case using jax and jax plugins.

Fixes #3228
@pull pull Bot locked and limited conversation to collaborators Oct 11, 2025
@pull pull Bot added the ⤵️ pull label Oct 11, 2025
@pull pull Bot merged commit f84640b into garymm:main Oct 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant